fix: ignore server-side production trigger bits in transport class trigger parsing#600
Open
MrAlaskan wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
ConnectionObjectGetTransportClassTriggerProductionTrigger()ignore production trigger bits when theTransport Class Triggerdirection bit indicatesServerbehavior.Problem
The
ConnectionObjectTransportClassTriggerDirectioncomment incipconnectionobject.halready states that forServerbehavior, the production trigger bits are to be ignored.However,
ConnectionObjectGetTransportClassTriggerProductionTrigger()previously decoded the trigger bits without first checking the direction bit. If the encoded trigger value was not one of the explicitly supported client-side trigger types, the function returnedInvalid.HandleNonNullNonMatchingForwardOpenRequest()then treated thatInvalidresult as an unsupported transport-class-and-trigger combination and rejected theForward Openrequest before connection path parsing and normal connection setup could proceed.As a result,
Serverdirection connections could be rejected only because they carried production trigger bits that the implementation's own comment says should be ignored.Changes
Transport Class Triggerdirection before decoding the production trigger bits.Serverdirection connections so that ignored trigger bits no longer cause a spuriousForward Openrejection.Serverdirection connections no longer map ignored trigger bits toInvalid.